Skip to content

bpo-39594: Fix typo in os.times documentation#18443

Merged
miss-islington merged 1 commit into
python:masterfrom
rogerhurwitz:bpo-39594
Feb 10, 2020
Merged

bpo-39594: Fix typo in os.times documentation#18443
miss-islington merged 1 commit into
python:masterfrom
rogerhurwitz:bpo-39594

Conversation

@rogerhurwitz

@rogerhurwitz rogerhurwitz commented Feb 10, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

There was an extra space in the url markup, causing the documentation not rendered properly.

https://bugs.python.org/issue39594

Automerge-Triggered-By: @Mariatta

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 10, 2020
@Mariatta Mariatta changed the title bpo-39594: Fixed typo identified by issue submitter. bpo-39594: Fix typo in os.times documentation Feb 10, 2020
@Mariatta

Mariatta commented Feb 10, 2020

Copy link
Copy Markdown
Member

Thanks for the PR. I think it looks good. For future, it really would be helpful to describe the change made in this pr instead of "fix issue reported by submitter". (I've changed your PR title and description).

@miss-islington miss-islington merged commit 37c55b2 into python:master Feb 10, 2020
@miss-islington

miss-islington commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Thanks @rogerhurwitz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2020
@rogerhurwitz @miss-islington
bpo-39594: Fix typo in os.times documentation (pythonGH-18443)
b98a8a4 
There was an extra space in the url markup, causing the documentation not rendered properly.

https://bugs.python.org/issue39594
(cherry picked from commit 37c55b2)

Co-authored-by: Roger Hurwitz <rogerhurwitz@gmail.com>
@bedevere-bot

bedevere-bot commented Feb 10, 2020

Copy link
Copy Markdown

GH-18444 is a backport of this pull request to the 3.7 branch.

@rogerhurwitz rogerhurwitz deleted the bpo-39594 branch February 10, 2020 22:50
@miss-islington

miss-islington commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Thanks @rogerhurwitz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2020
@rogerhurwitz @miss-islington
bpo-39594: Fix typo in os.times documentation (pythonGH-18443)
3de9ba1 
There was an extra space in the url markup, causing the documentation not rendered properly.

https://bugs.python.org/issue39594
(cherry picked from commit 37c55b2)

Co-authored-by: Roger Hurwitz <rogerhurwitz@gmail.com>
@bedevere-bot

bedevere-bot commented Feb 10, 2020

Copy link
Copy Markdown

GH-18447 is a backport of this pull request to the 3.8 branch.

@rogerhurwitz

rogerhurwitz commented Feb 10, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback - will make the PR text more descriptive in the future.

miss-islington added a commit that referenced this pull request Feb 10, 2020
@miss-islington @rogerhurwitz
bpo-39594: Fix typo in os.times documentation (GH-18443)
a12effd 
There was an extra space in the url markup, causing the documentation not rendered properly.

https://bugs.python.org/issue39594
(cherry picked from commit 37c55b2)

Co-authored-by: Roger Hurwitz <rogerhurwitz@gmail.com>
miss-islington added a commit that referenced this pull request Feb 10, 2020
@miss-islington @rogerhurwitz
bpo-39594: Fix typo in os.times documentation (GH-18443)
4d43017 
There was an extra space in the url markup, causing the documentation not rendered properly.

https://bugs.python.org/issue39594
(cherry picked from commit 37c55b2)

Co-authored-by: Roger Hurwitz <rogerhurwitz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rogerhurwitz @Mariatta @miss-islington @bedevere-bot @the-knights-who-say-ni